Add unhelpful button #330
Merged
Add unhelpful button #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprillion
requested changes
Oct 1, 2023
app/server-utils/stampy.ts
Outdated
| @@ -452,3 +452,5 @@ export const incAnswerColumn = async (column: string, pageid: PageId, subtract: | |||
|
|
|||
| export const makeColumnIncrementer = (column: string) => (pageid: PageId, subtract: boolean) => | |||
| incAnswerColumn(column, pageid, subtract) | |||
| export const makeColumnDecrementer = (column: string) => (pageid: PageId, subtract: boolean) => | |||
| incAnswerColumn(column, pageid, !subtract) | |||
There was a problem hiding this comment.
eeh, !subtract?!? 😖
TBH, I would prefer to have 2 columns in Coda to track helpful and unhelpful (2 - 1 has a different vibe from 100 - 99), but if it's already decided that we want only 1 column please get rid of the subtract parameter from all places, replacing it with a decAnswerColumn function (or some better way)
There was a problem hiding this comment.
There are now 2 columns
Aprillion
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One downside of this is that an article can be both liked and disliked at the same time. Though that can be a feature not a bug!